[linux-cifs-client] Re: [patch 2.6.15-mm4] fix warning in fs/cifs/cifssmb.c

[Steven French]

Benoit Boissinot wrote:
      Fix the following warning, (i couldn't find where 'struct sec_desc'
      was
      defined).

      fs/cifs/cifssmb.c: In function jCIFSSMBGetCIFSACL':
      fs/cifs/cifssmb.c:2573: warning: passing argument 1 of
      'parse_sec_desc' from incompatible pointer type

      Signed-off-by: Benoit Boissinot <benoit.boissinot at ens-lyon.org>


      --- a/fs/cifs/cifssmb.c        2006-01-14 23:53:45.000000000 +0100
      +++ b/fs/cifs/cifssmb.c.new          2006-01-14 23:53:37.000000000
      +0100
      @@ -2542,7 +2542,7 @@
                   if (rc) {
                               cFYI(1, ("Send error in QuerySecDesc = %d",
      rc));
                   } else {                /* decode response */
      -                        struct sec_desc * psec_desc;
      +                        struct cifs_sid * psec_desc;
                               __le32 * parm;
                               int parm_len;
                               int data_len;


Benoit,
Your patch for the warning is fine, similar to a change that I had not
pushed into the cifs-2.6.git tree from my local development system (there
is also one additional compiler warning that newer gcc throws, an unrelated
issue in fs/cifs/file.c) .  Although this path is disabled - I felt that it
was important to get this to get the code out and people part way by doing
some of the more obscure CIFS related part of this in the hope that someone
would finish off the CIFS ACL to mode and (CIFS ACL to POSIX ACL) parsing
(and this same kind of code will be needed for NFS ACL to mode and NFS ACL
to POSIX ACL eventually so it seemed likely that someone would take an
interest - it is an interesting issue and similar things have been done in
cygwin, Samba, SFU and various other places - presumably even Linux NTFS
would have to do something similar).


Steve French
Senior Software Engineer
Linux Technology Center - IBM Austin
phone: 512-838-2294
email: sfrench at-sign us dot ibm dot com
-------------- next part --------------
HTML attachment scrubbed and removed