[linux-cifs-client] Re: Incorrect FIND_NEXT2 transmission causing

[Richard Hughes]

Can I refactor cifs_readdir into separate functions? 
The current switch case is huge!
Assuming I keep the logic the same, the "current_dir", 
"parent_dir", "empty_dir" and the "default" case could be split 
into 4 different functions to make the code more modular.

Objections?

 Richard Hughes

 
> > I still do not like the search logic (cifs_readdir) code - it is just about my least favority part
> > of the code that I wrote - the NFS approach (grabbing a cache of NFS private pages to keep 
> > the search results in until the last readdir is issued and the search is closed may be a better
> > approach - but the memory utilization worries me)