[linux-cifs-client] Re: fcntl method for file_operations

viro at parcelfarce.linux.theplanet.co.uk viro at parcelfarce.linux.theplanet.co.uk
Thu Mar 25 20:34:48 GMT 2004


On Thu, Mar 25, 2004 at 02:25:58PM -0600, Steve French wrote:
> passed to network filesystems and filesystems without true block
> devices.   Current sys_quotactl does	
> 	bdev = lookup_bdev(name)
> then
> 	get_super(bdev)
> 
> rather than looking up the superblock directly from the name (using
> user_path_walk as sys_statfs and other places in the kernel do) so that
> small section of quota.c needs to be modified for non-local and
> deviceless filesystems.

That's not a VFS problem - it's a bad syscall API.  Note that statfs(2)
uses pathname of mountpoint (anything on fs, actually).  quotactl(2)
uses pathname of _device_.  Which is, indeed, a bad idea, but we are
tied by user-visible API here.


More information about the linux-cifs-client mailing list