[jcifs] Thread Leak part deux

David McReynolds david.mcreynolds at gmail.com
Thu Apr 1 12:13:55 MDT 2010


What is this supposed to do?

            if (false && NETBIOS_HOSTNAME != null &&
NETBIOS_HOSTNAME.equals( "" ) == false) {
                port = 139;
            }

How about

            if ((NETBIOS_HOSTNAME != null) &&
(!NETBIOS_HOSTNAME.equals( "" ))) {


Also, since this was the last response concerning something that could
be fixed in 4 lines of code. I am posting this little code snippet
because if I let my daemon run overnight it ends up with 1800 blocked
threads.



More information about the jCIFS mailing list