[jcifs] Problem with jcifs.UniAddress.isValidDnsName(String)

[Spierenburg, Peter]

Greetings,
 
There appears to be a bug in the jcifs.UniAddress.isValidDnsName(String)
method. As it stands in the 1.2.5 release, this method rejects dns names
which begin with a digit. This is unfortunate since digits are permitted
first characters in dns names. As a result, I propose changing the
method to use a regular expression:
 
import java.util.regex.Pattern;
 
static boolean isValidDnsName( String hostname ) {
    Pattern p =
Pattern.compile("[a-zA-Z0-9][a-zA-Z0-9\\055]*([\\056][a-zA-Z0-9][a-zA-Z0
-9\055]*)*");
    return p.matcher(hostname).matches();
}

which I believe more accurately expresses the nature of dns names.

Does this seem reasonable?
 
Peter-Frank Spierenburg.
 
-------------- next part --------------
HTML attachment scrubbed and removed