[distcc] Problem with distcc doing remote compiles locally

[Martin Pool]

On  2 Mar 2006, Dan Kegel <dank at kegel.com> wrote:
> On 3/2/06, Martin Pool <mbp at sourcefrog.net> wrote:
> > I think there is a bug in the select-for-write loop that Dan added to
> > dcc_connect_by_addr:
> 
> The loop is visible here, for those following along at home:
> http://archzoom.sourcecontrol.net/archzoom.cgi/mbp@sourcefrog.net--2004/distcc--devel--2--patch-170/src/clinet.c
> 
> > Perhaps that check should be hoisted out of the loop.
> 
> Yeah, the first check in the loop (the one that checks for EINPROGRESS)
> clearly should be outside the loop - it's there to check for immediate connect
> errors.  Also, 'failed' never changes inside the loop.

OK fixed in arch.
-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: Digital signature
Url : http://lists.samba.org/archive/distcc/attachments/20060303/c5417e06/attachment-0001.bin