[distcc] patch: -Wa,-xarch=v8 incorrectly not distributed

[Martin Pool]

On 23 Jan 2004, Ben Scarlet <bscarlet at endeca.com> wrote:
> The following patch makes the processing of arguments passed through to the
> assembler slightly less conservative. When compiling 32-bit sparc code with
> gcc-2.95.3, it is sometimes necessary to tweak assembler's notion of the
> architecture to allow for the use of some fancier instructions.

I merged this:

Index: arg.c
===================================================================
RCS file: /data/cvs/distcc/src/arg.c,v
retrieving revision 1.103
diff -u -p -r1.103 arg.c
--- arg.c	29 Feb 2004 04:05:35 -0000	1.103
+++ arg.c	29 Feb 2004 04:28:45 -0000
@@ -172,15 +172,11 @@ int dcc_scan_args(char *argv[], char **i
                 rs_trace("%s implies -E (maybe) and must be local", a);
                 return EXIT_DISTCC_FAILED;
             } else if (str_startswith("-Wa,", a)) {
-                /* Options passed through to the assembler.  The only one we
-                 * need to handle so far is -al=output, which directs the
-                 * listing to the named file and cannot be remote.  Parsing
-                 * all the options would be complex since you can give several
-                 * comma-separated assembler options after -Wa, but looking
-                 * for '=' should be safe. */
-                if (strchr(a, '=')) {
-                    rs_trace("%s needs to write out assembly listings and must be local",
-                         a);
+                /* Look for assembler options that would produce output
+                 * files and must be local. */
+                if (strstr(a, ",-a") || strstr(a, "--MD")) {
+                    rs_trace("%s must be local",
+                             a);
                     return EXIT_DISTCC_FAILED;
                 }
             } else if (!strcmp(a, "-S")) {


-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.samba.org/archive/distcc/attachments/20040229/a4ab44e7/attachment.bin