[distcc] -x argument processing bug

Martin Pool mbp at sourcefrog.net
Sun Feb 29 04:03:11 GMT 2004


On 28 Jan 2004, Ben Scarlet <bscarlet at endeca.com> wrote:
> In args.c, distcc uses !strcmp(a, "-x") to check for gcc's language
> specification flag. However, gcc accepts languages both with and without
> whitespace separating the -x from the language. For example, a Makefile
> might say
> g++ -x c++ -c foo.c -o foo.o
> to get foo.c compiled as c++, but it could also say
> g++ -xc++ -c foo.c -o foo.o
> 
> It would be nice to implement the fancy -x rewriting proposed in the top of
> the file, but in the meantime I suggest the strict equality comparison be
> replaced with str_startswith("-x", a)

Done in CVS.  Thanks.

-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.samba.org/archive/distcc/attachments/20040229/5768e8f1/attachment.bin


More information about the distcc mailing list