[distcc] Problem running from init

[George Garvey]

On Wed, May 28, 2003 at 02:48:36PM +1000, Martin Pool wrote:
> On 27 May 2003, George Garvey <tmwg-distcc at inxservices.com> wrote:
> >    Just switched from inetd to init on Linux 2.4.20, glibc 2.3.2.
> > setpgid fails under these conditions. Removed it, and everything's
> > happy. Perhaps I'm not using the right set of options.
> 
> Thanks for reporting it.  The options look reasonable, but there was a
> bug in distcc that made it fail when run by init.
> 
> > Index: inX.16/src/dparent.c
> > +++ inX.17/src/dparent.c Tue, 27 May 2003 03:38:11 -0700 tmwg (distcc/35_dparent.c 1.13 640)
> > @@ -126,8 +126,10 @@ int dcc_standalone_server(void)
> >      } else {
> >          /* Still create a new process group, even if not detached */
> >          rs_trace("not detaching");
> > +/*
> >          if ((ret = dcc_setpgid(0, 0)) != 0)
> >              return ret;
> > +*/
> >          dcc_save_pid(getpid());
> >      }
> 
> That fixes init but would break other uses of --no-detach, such as
> running from a debugger..  It's better to just insert a check beforehand:

I removed my kludge, and called your fix. Everything is working fine.