[cifs-protocol] MS-PAC new buffers 17 and 18 - TrackingID#2112060040006918

[Jeff McCashland (He/him)]

Hi All,

We have updated [MS-PAC] for the next release:

2.4 PAC_INFO_BUFFER
0x00000011	PAC Attributes indicates that the buffer contains attribute bits for the PAC (section 2.14). PAC structures SHOULD NOT contain more than one buffer of this type. Additional attribute buffers MUST be ignored.<8>
0x00000012	PAC Requestor indicates that the buffer contains the SID of principal that requested the PAC (section 2.15). PAC structures MUST contain one buffer of this type.<9>

<8> Section 2.4: The PAC Attributes value is not supported in Windows Server 2008 Service Pack 1 and earlier.
<9> Section 2.4: The PAC Requestor value is not supported in Windows Server 2008 Service Pack 1 and earlier.

Best regards,
Jeff McCashland (He/him) | Senior Escalation Engineer | Microsoft Protocol Open Specifications Team 
Phone: +1 (425) 703-8300 x38300 | Hours: 9am-5pm | Time zone: (UTC-08:00) Pacific Time (US and Canada)
Local country phone number found here: http://support.microsoft.com/globalenglish | Extension 1138300
We value your feedback.  My manager is Natesha Morrison (namorri), +1 (704) 430-4292

-----Original Message-----
From: Obaid Farooqi <obaidf at microsoft.com> 
Sent: Monday, December 6, 2021 10:01 AM
To: Isaac Boukris <iboukris at gmail.com>; Greg Hudson <ghudson at mit.edu>; cifs-protocol at lists.samba.org; metze <metze at samba.org>; Andrew Bartlett <abartlet at samba.org>; josephsutton at catalyst.net.nz
Cc: Obaid Farooqi <obaidf at microsoftsupport.com>
Subject: MS-PAC new buffers 17 and 18 - TrackingID#2112060040006918

Hi Isaac:
Thanks for brining this to our attention. While you found the answer, we would still like to include this info in our documentation. We will look into this and a bug will be filed against the document MS-PAC if needed

Regards,
Obaid Farooqi
Escalation Engineer | Microsoft

-----Original Message-----
From: Isaac Boukris <iboukris at gmail.com>
Sent: Saturday, December 4, 2021 11:48 AM
To: Interoperability Documentation Help <dochelp at microsoft.com>; Greg Hudson <ghudson at mit.edu>; cifs-protocol at lists.samba.org; metze <metze at samba.org>; Andrew Bartlett <abartlet at samba.org>; josephsutton at catalyst.net.nz
Subject: [EXTERNAL] Re: MS-PAC new buffers 17 and 18

Looking at samba code I can see these correspond to:

                PAC_TYPE_ATTRIBUTES_INFO = 17,
                PAC_TYPE_REQUESTER_SID = 18

Please ignore my request, thanks.

On Sat, Dec 4, 2021 at 3:48 PM Isaac Boukris <iboukris at gmail.com> wrote:
>
> Hello dochelp,
>
> Looking at a fresh PAC from an updated win2019 DC, it appears two new 
> buffers were added, namely 17 and 18, as in this ticket.
>
> ad-type: aD-WIN2K-PAC (128)
> ad-data: 070000000000000001000000d801000078000000000000000a0000002400000050020000…
>     Num Entries: 7
>     Version: 0
>     Type: Logon Info (1)
>     Type: Client Info Type (10)
>     Type: UPN DNS Info (12)
>     Type: Unknown (17)
>     Type: Unknown (18)
>     Type: Server Checksum (6)
>     Type: Privsvr Checksum (7)
>
> Can you please document these two new buffer types in the 
> corresponding table in MA-PAC 2.4 PAC_INFO_BUFFER table and their 
> corresponding logic.
>
> Thanks