[cifs-protocol] [REG:119072621001605] [MS-SMB2] 2.2.3.1.4 SMB2_NETNAME_NEGOTIATE_CONTEXT_ID

[Bryan Burgin]

[Dochelp to bcc]
[+support]

Hi Metze

Thank you for your question.  We created SR 119072621001605 to track this issue.  An engineer will contact you soon.

Bryan

-----Original Message-----
From: Stefan Metzmacher <metze at samba.org> 
Sent: Friday, July 26, 2019 1:23 AM
To: Interoperability Documentation Help <dochelp at microsoft.com>; cifs-protocol at lists.samba.org
Subject: [MS-SMB2] 2.2.3.1.4 SMB2_NETNAME_NEGOTIATE_CONTEXT_ID

Hi DocHelp,

I just noticed a documentation bug in
[MS-SMB2] 2.2.3.1.4 SMB2_NETNAME_NEGOTIATE_CONTEXT_ID:

   NetName (variable): A null-terminated Unicode string containing the
   server name and specified by the client application.

Windows Server 1903 sends the name without null-termination, see the attached capture.

Metze

==

Hi Steve,

I just contacted dochelp for this and noticed (from reading the code) that the kernel sends null-termination for the SMB2_NETNAME_NEGOTIATE_CONTEXT_ID value.

I think you should fix that and backport it to stable releases, it would be good if all clients would implement it like windows.

I implemented it for Samba here:
https://gitlab.com/samba-team/samba/merge_requests/666

metze