[cifs-protocol] MS-FSRVP hidden share shadow copies

[David Disseldorp]

Dear Dochelp,

The [MS-FSRVP] document defines Windows specific behaviour for handling
FSRVP ExposeShadowCopySet requests against share shadow copies when the
base share includes a trailing '$' (a hidden share):

  [MS-FSRVP] 7 Appendix B
  ...
  <8> Section 3.1.4.6: Windows servers expose the shadow copy of the
  share by invoking the NetrShareAdd() method, as specified in [MS-SRVS]
  section 3.1.4.7.
  If MappedShare.ShareName ends with a '$' character (meaning that the
  share is hidden), then the exposed share name will have the '$' suffix
  appended.
  For example, if MappedShare.ShareName is \\server\thisshare$, the
  exposed name would be \\<any>\thisshare$@{ShadowCopy.ShadowCopyId}$

I've not been able to reproduce this behaviour against the Windows
Server 2012 FSRVP server - the '$' character is not appended to the
resulting shadow copy share.
E.g. With a MappedShare.ShareName of \\server\hidden_share$, the
resulting shadow copy share is
\\server\hidden_share$@{ShadowCopy.ShadowCopyId}

Can you confirm this behaviour? If so I'd suggest removing this clause.

Regards, David