[ccache] -fdiagnostics-color problem

[Joel Rosdahl]

Hi Steven,

> also get a build problem with -fdiagnostics-color enabled. With gcc4.9.2
> in `make test` I get: [...]

Right, the tests get confused by GCC_COLORS being set. Should be fixed by
the attached patch.

-- Joel

On 18 November 2014 19:03, Steven Honeyman <stevenhoneyman at gmail.com> wrote:

> I also get a build problem with -fdiagnostics-color enabled. With
> gcc4.9.2 in `make test` I get:
>
>
> test/main
> test/test_argument_processing.c:199: Failed assertion:
>   Suite:      argument_processing
>   Test:       MQ_flag_without_immediate_argument_should_not_add_MQobj
>   Expression: act_cpp
>   Expected:   gcc -MD -MP -MFfoo.d -MQ foo.d
>   Actual:     gcc -fdiagnostics-color -MD -MP -MFfoo.d -MQ foo.d
>
> test/test_argument_processing.c:216: Failed assertion:
>   Suite:      argument_processing
>   Test:       MT_flag_without_immediate_argument_should_not_add_MTobj
>   Expression: act_cpp
>   Expected:   gcc -MD -MP -MFfoo.d -MT foo.d
>   Actual:     gcc -fdiagnostics-color -MD -MP -MFfoo.d -MT foo.d
>
> test/test_argument_processing.c:233: Failed assertion:
>   Suite:      argument_processing
>   Test:       MQ_flag_with_immediate_argument_should_not_add_MQobj
>   Expression: act_cpp
>   Expected:   gcc -MD -MP -MFfoo.d -MQfoo.d
>   Actual:     gcc -fdiagnostics-color -MD -MP -MFfoo.d -MQfoo.d
>
> test/test_argument_processing.c:250: Failed assertion:
>   Suite:      argument_processing
>   Test:       MT_flag_with_immediate_argument_should_not_add_MQobj
>   Expression: act_cpp
>   Expected:   gcc -MD -MP -MFfoo.d -MTfoo.d
>   Actual:     gcc -fdiagnostics-color -MD -MP -MFfoo.d -MTfoo.d
>
> test/test_argument_processing.c:275: Failed assertion:
>   Suite:      argument_processing
>   Test:
>  fprofile_flag_with_existing_dir_should_be_rewritten_to_real_path
>   Expression: act_cpp
>   Expected:   gcc
>
> -fprofile-generate=/tmp/makepkg/ccache-git/src/ccache/testdir.20931/argument_processing/fprofile_flag_with_existing_dir_should_be_rewritten_to_real_path/some/dir
>   Actual:     gcc
>
> -fprofile-generate=/tmp/makepkg/ccache-git/src/ccache/testdir.20931/argument_processing/fprofile_flag_with_existing_dir_should_be_rewritten_to_real_path/some/dir
> -fdiagnostics-color
>
> test/test_argument_processing.c:294: Failed assertion:
>   Suite:      argument_processing
>   Test:       fprofile_flag_with_nonexisting_dir_not_be_rewritten
>   Expression: act_cpp
>   Expected:   gcc -fprofile-generate=some/dir
>   Actual:     gcc -fprofile-generate=some/dir -fdiagnostics-color
>
> FAILED: 6 tests
> _______________________________________________
> ccache mailing list
> ccache at lists.samba.org
> https://lists.samba.org/mailman/listinfo/ccache
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-test-Unset-GCC_COLORS-to-avoid-confusing-argument-pr.patch
Type: text/x-patch
Size: 1478 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/ccache/attachments/20141119/28954bd5/attachment.bin>