[ccache] [PATCH] Detect __DATE__ and __TIME__ correctly.
joel at rosdahl.net
Sun Nov 4 06:55:33 MST 2012
Andrew: Could you send the latest version of the patch to the list?
(It looks like you only replied to Justin in private.)
On 9 October 2012 17:28, Justin Lebar <justin.lebar at gmail.com> wrote:
> Okay, I think this is right. Thanks a lot for fixing my bug. :)
> It's not so surprising that the tests pass as-is, since we only test
> one offset of "__TIME__". But I tried modifying test.sh to move
> "__TIME__" to different offsets, and everything still worked.
> We should really get test coverage of this, since it's obviously
> tricky to get right!
> On Tue, Oct 9, 2012 at 11:05 AM, Andrew Stubbs <andrew_stubbs at mentor.com> wrote:
>> On 09/10/12 15:46, Justin Lebar wrote:
>>> Can you update the Python script in the comment right above the code
>>> and confirm that it matches your new table? It's hard for me to see
>>> what you did here based on just the patch...
>> In fact, I did do that. I just cocked up the git magic and didn't post it. I
>> guess I need more sleep!
>> I've also removed the unnecessary comma change.
>> New version attached, again.
> ccache mailing list
> ccache at lists.samba.org
More information about the ccache