[ccache] [PATCH] Detect __DATE__ and __TIME__ correctly.

Andrew Stubbs ams at codesourcery.com
Tue Oct 9 08:43:07 MDT 2012

On 08/10/12 19:25, Justin Lebar wrote:
> I think this fails on at least one edge case: If the file contains
> only the string "__date__", then len == i == 8 and we never enter the
> loop, right?  I think we in general fail to detect temporal macros at
> the very end of the file, with this patch.
> The solution isn't as simple as making it |i <= len|, of course,
> because the end of the loop reads str[i].

Grrr, those pesky fenceposts!

Ok, after looking at it some more, I think the correct solution is to 
fix the table, not the code.

New patch attached.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Detect-__DATE__-and-__TIME__-correctly.patch
Type: text/x-patch
Size: 2157 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/ccache/attachments/20121009/6375c194/attachment.bin>

More information about the ccache mailing list