[ccache] [PATCH] add support for '@' parameters

Boie, Andrew P andrew.p.boie at intel.com
Mon Jul 30 15:09:24 MDT 2012

> -----Original Message-----
> From: joel.rosdahl at gmail.com [mailto:joel.rosdahl at gmail.com] On Behalf Of
> Joel Rosdahl
> > +                       file_args = args_init_from_string(argdata);
> Isn't args_init_from_string too simplistic for parsing the contents?

Oof, yeah you're right. It seems that args_init_from_string needs to be significantly beefed-up. I don't suppose you know of some library code somewhere that does this? I should dig into the bash sources, IIRC it's the shell that turns the string into argv array...

> It would be nice if this code could be extracted to a new
> args_insert(struct args *args, struct args *to_insert, int pos)
> function or so. (There's a test suite for args_* in test/test_args.c.)

Done. I'll add a test case as well.


More information about the ccache mailing list