[Samba] renaming over to a busy file: traces

[Michael Tokarev]

19.03.2024 19:50, Jeremy Allison via samba wrote:

>> The traces attached are from the operation #5.
> 
> Sorry Michael, traces are stipped from the mailing list I think.
> 
> This is an excellent summary of the bug. Can you open a bug
> report in our bugzilla and use this text as the descriptor and add the
> traces there.

Here: https://bugzilla.samba.org/show_bug.cgi?id=15608

> The only thing that would be helpful would be the version
> of the Linux kernel being used in case we need the same
> version of the SMB2 client to reproduce (unlikely, but
> still good to know).

Does not look like it depends on kernel version (at least a few non-ancient
kernels shows the same behavior).

>> It looks to me that while renaming a file, samba checks only if the SOURCE
>> file is locked, but not if the DESTINATION file is locked.
> 
> This indeed looks to be the case, after at a quick glance at the
> code. Probably my fault, as I wrote the inital rename logic a *looong*
> time ago :-(.

Heh. It's nice to find a bug in a code you wrote long time ago.
I know this feeling ;)

Thanks,

/mjt