From 553781e020bc02fbd770f45c6b2fe232b112d1d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Jacke?= Date: Wed, 19 Jun 2019 13:04:55 +0200 Subject: [PATCH 1/3] param: change default of "allocation roundup size" to 0 Signed-off-by: Bjoern Jacke --- lib/param/loadparm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c index e03c1556d7e0..b2982dec6107 100644 --- a/lib/param/loadparm.c +++ b/lib/param/loadparm.c @@ -2889,7 +2889,7 @@ struct loadparm_context *loadparm_init(TALLOC_CTX *mem_ctx) lpcfg_do_global_parameter(lp_ctx, "show add printer wizard", "yes"); - lpcfg_do_global_parameter(lp_ctx, "allocation roundup size", "1048576"); + lpcfg_do_global_parameter(lp_ctx, "allocation roundup size", "0"); lpcfg_do_global_parameter(lp_ctx, "ldap page size", "1000"); -- 2.17.1 From 9aa693f65d09be2f6e870da539ca18a8ba48f9c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Jacke?= Date: Wed, 19 Jun 2019 13:15:54 +0200 Subject: [PATCH 2/3] docs-xml: improve documentation and new default of "allocation roundup size" Signed-off-by: Bjoern Jacke --- .../smbdotconf/tuning/allocationroundupsize.xml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/docs-xml/smbdotconf/tuning/allocationroundupsize.xml b/docs-xml/smbdotconf/tuning/allocationroundupsize.xml index eaea467bc390..aabbba32655a 100644 --- a/docs-xml/smbdotconf/tuning/allocationroundupsize.xml +++ b/docs-xml/smbdotconf/tuning/allocationroundupsize.xml @@ -4,17 +4,21 @@ xmlns:samba="http://www.samba.org/samba/DTD/samba-doc"> This parameter allows an administrator to tune the - allocation size reported to Windows clients. The default - size of 1Mb generally results in improved Windows client - performance. However, rounding the allocation size may cause + allocation size reported to Windows clients. This is only + useful for old SMB1 clients because modern SMB dialects + eliminated that bottleneck and have better performance by + default. Using this parameter may cause difficulties for some applications, e.g. MS Visual Studio. If the MS Visual Studio compiler starts to crash with an internal error, set this parameter to zero for this share. + Settings this parameter to a large value can also cause + small files to allocate more space on the disk than + needed. The integer parameter specifies the roundup size in bytes. -1048576 -0(to disable roundups) +0 +1048576(to set it to the former default of 1 MiB) -- 2.17.1 From 533090c97320223706b253147e1d621f08af25a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Jacke?= Date: Wed, 19 Jun 2019 13:20:34 +0200 Subject: [PATCH 3/3] docs-xml: deprecate allocation roundup size parameter --- docs-xml/smbdotconf/tuning/allocationroundupsize.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs-xml/smbdotconf/tuning/allocationroundupsize.xml b/docs-xml/smbdotconf/tuning/allocationroundupsize.xml index aabbba32655a..08aa621fcc53 100644 --- a/docs-xml/smbdotconf/tuning/allocationroundupsize.xml +++ b/docs-xml/smbdotconf/tuning/allocationroundupsize.xml @@ -1,6 +1,7 @@ This parameter allows an administrator to tune the @@ -15,6 +16,9 @@ small files to allocate more space on the disk than needed. + This parameter is deprecated and will be removed in + one of the next Samba releases. + The integer parameter specifies the roundup size in bytes. -- 2.17.1