>From fc6d208c1f8528de499b524d607eb3e2dd7d2833 Mon Sep 17 00:00:00 2001 From: Matthieu Patou Date: Wed, 8 Feb 2017 12:01:50 -0800 Subject: [PATCH 2/3] wafsamba: Remove 2010 comments that seems not accurate anymore In my tests default value is correctly used and if we provide explicitly a --with it will comply with the store_true and if we provide --without then it will comply with the store_false Change-Id: I820a7f2f08c51ec23b694bce7009c3891d4ab8ef Signed-off-by: Matthieu Patou --- buildtools/wafsamba/samba_utils.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/buildtools/wafsamba/samba_utils.py b/buildtools/wafsamba/samba_utils.py index f5c0c53..0f95c12 100644 --- a/buildtools/wafsamba/samba_utils.py +++ b/buildtools/wafsamba/samba_utils.py @@ -689,8 +689,6 @@ def samba_add_onoff_option(opt, option, help=(), dest=None, default=True, with_val = "--%s-%s" % (with_name, option) without_val = "--%s-%s" % (without_name, option) - #FIXME: This is broken and will always default to "default" no matter if - # --with or --without is chosen. opt.add_option(with_val, help=help, action="store_true", dest=dest, default=default) opt.add_option(without_val, help=SUPPRESS_HELP, action="store_false", -- 2.7.4