Regards, -Shyam > On Mar 17, 2016, at 11:55 AM, Jeremy Allison wrote: > > On Thu, Mar 17, 2016 at 08:30:52PM +0200, Uri Simchoni wrote: >> On 03/17/2016 06:49 PM, Jeremy Allison wrote: >>> On Fri, Mar 11, 2016 at 04:46:59PM -0800, Jeremy Allison wrote: >>>> On Fri, Mar 11, 2016 at 01:38:57AM +0000, Shyam Rathi wrote: >>>>> Thanks Jeremy. >>>>> I’ve made the change as per your suggestion. >>>>> >>>>> Updated patch attached. >>>> >>>> LGTM. Reviewed-by: Jeremy Allison >>>> >>>> Can I get a second Team reviewer ? >>> >>> Ping. Can I get a second Team reviewer please ? >>> >> >> + char *rootdir; >> That should be char *rootdir = NULL; - By our coding standards but >> what's more - it causes a talloc of uninitialized value if you jump >> to fail before initializing rootdir. >> >> I would just fix it and push but I have one more nit-pickiness: >> Seems to me like lp_parm_talloc_string() should be checked for NULL >> (talloc failure) whereas lp_parm_const_string() didn't have to. > > Great catch Uri - this is why I'm glad we have 2 reviewers :-). > > Shyam, can you fix both of these and re-submit the patch > please ?