Bug in nmbd_become_dmb.c (CVS 1.7 3.somehting) [patch]

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 22 Jan 2003, Damjan "Zobo" Cvetko wrote:

> I dont know if this is the rigth list for this..
> I'm using the latest samba 3.x. from CVS.. (because of the wins replication)
> I have it set up as master browser, but it wont register itself (to the WINS
> server running in the same nmbd) as DMB (WROKGROUP#1b..)

Why not just set

	domain master = yes
	domain logons = yes

?

By not setting domain logons, you've created a box that Windows clients 
will believe to be a PDC but one that will not be listed in the DOMAIN#1c
list of addresses.

>    /* Do the domain master names. */
> -  if(lp_server_role() == ROLE_DOMAIN_PDC)
> +  if (lp_domain_master() == True)
>    {

I don't think i will commit this patch unless you can further convince me.




cheers, jerry
 ----------------------------------------------------------------------
 Hewlett-Packard            ------------------------- http://www.hp.com
 SAMBA Team                 ---------------------- http://www.samba.org
 GnuPG Key                  ---- http://www.plainjoe.org/gpg_public.asc
 ISBN 0-672-32269-2         "SAMS Teach Yourself Samba in 24 Hours" 2ed
 "You can never go home again, Oatman, but I guess you can shop there."  
                            --John Cusack - "Grosse Point Blank" (1997)


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.0 (GNU/Linux)
Comment: For info see http://quantumlab.net/pine_privacy_guard/

iD8DBQE+NZ/kIR7qMdg1EfYRAqbGAKDtsGG8fo+025Zt8epRB32kINa8mACgi2V8
nl5zKAaKX+ImH6OjyxHZ41Q=
=LGOw
-----END PGP SIGNATURE-----