homes share and NIS

[Juergen Hasch]

Hi,

 I am testing Samba on a Linux server acting as NIS slave server.
 With the current 2.2 CVS I can't connect the homes-shares any
 more. 
The configuration of my share looks like this:
 [homes]
         comment = home share
         path = /home/%S
         read only = No

 When I try to connect to the share I get the following messages
 in my smbd logfile: 

 [2002/01/15 13:34:14, 3] smbd/service.c:find_service(141)
   checking for home directory juhasch gave /home/homes
 [2002/01/15 13:34:14, 3] smbd/service.c:find_service(209)
   find_service() failed to find service juhasch
 [2002/01/15 13:34:14, 0] smbd/service.c:make_connection(249)
   sh0815 (192.168.0.1) couldn't find service juhasch
 [2002/01/15 13:34:14, 3] smbd/error.c:error_packet(115)
   error string = No such file or directory
 [2002/01/15 13:34:14, 3] smbd/error.c:error_packet(127)
   error packet at smbd/reply.c(165) cmd=117 (SMBtconX)
 NT_STATUS_BAD_NETWORK_NAME

 So my home directory gets /home/homes instead of /home/juhasch.
 It looks like this change to lib/username.c broke it for me:

 Revision 1.31.4.17 / (download) - annotate - [select for diffs] , Tue Dec 18
 08:06:02 2001 UTC (4 weeks ago) by jra 
Branch: SAMBA_2_2 
Changes since 1.31.4.16: +16 -0 lines
 Diff to previous 1.31.4.16 (colored) to branchpoint 1.31 (colored) 
Tim's fix to user pathname in homes share by default looks ok for 2.2.3.
 Needs testing though.
 Jeremy

After removing the changes it works fine again.
It seems get_user_home_dir doesn't expand %S to what I would expect.
My share gets mapped to /home/homes instead of /home/juhasch, which
doesn't exist, of course.
I have the same on another machine which is a NIS client, but not
on a machine without NIS.

 ...Juergen