<div class="gmail_quote">On Wed, Mar 16, 2011 at 11:52 AM, Mike Bombich <span dir="ltr"><<a href="mailto:mike@bombich.com" target="_blank">mike@bombich.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div><div><div><div>The receiver should probably just exit with RERR_UNSUPPORTED if the --protect-decmpfs option is used and the destination filesystem doesn't support it. I was hoping to provide failover to decompression for the --hfs-compression option, though, which is what the use of the compat flags offers.</div>
</div></div></div></div></blockquote><div><br></div><div>Yeah, I was thinking about that more, and will try to work something out. If I don't come up with something, I'll reserve this bit in the compat flags for hfs and put that back in.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div><div>Also, this same block of code should be present in x_lstat and x_fstat.</div>
</div></div></div></div></blockquote><div><br></div><div>Good point.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">
<div><div><div><div><div>I'm not clear why we call itemizing() here</div></div></div></div></div></div></blockquote><div><br></div><div>Because we want to know about each change that is made in the destination tree, even when a file is being hard-linked instead of copied. It needs to be itemized against what was there before, though, so that it shows things like if the hard-linked file is new, or if the changed file has a different time, or what not. The prior file at that point (if there was one) may not have been already hard-linked into the new hard-link cluster. Your original change (that set statret) broke the testsuite (it made a new file itemized as non-new) and my leaving the re-stat in broke other itemizing info. I've removed the changes from hlinks.c.</div>
<div><br></div><div>As for the extra xattr setting on hard-linked files, I think changing this line in receiver.c:</div><div><br></div><div><div><font class="Apple-style-span" face="'courier new', monospace"> if (preserve_xattrs && iflags & ITEM_REPORT_XATTR && do_xfers)</font></div>
</div><meta http-equiv="content-type" content="text/html; charset=utf-8"><div><br class="Apple-interchange-newline">To this:</div><div><br></div><div><font class="Apple-style-span" face="'courier new', monospace"> if (preserve_xattrs && BITS_SETnUNSET(iflags, ITEM_REPORT_XATTR, ITEM_XNAME_FOLLOWS) && do_xfers)</font></div>
<div><br></div><div>Should avoid the extra xattr-setting on a hard-linked file. I've updated the git version of the patch with your latest fixes and this change. Thanks!</div><div></div></div><div><br></div>..wayne..<br>