<div class="gmail_quote">On Fri, Mar 11, 2011 at 8:05 AM, Mike Bombich <span dir="ltr"><<a href="mailto:mike@bombich.com" target="_blank">mike@bombich.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">FWIW, I updated <a href="http://www.bombich.com/rsync.html" target="_blank">http://www.bombich.com/rsync.html</a> just recently with a minor bug fix to my HFS+ compression patch (preserving resource forks when --fileflags was not used).</div>
</blockquote><div><br></div><div>I looked over your patch to see about getting it adapted for 3.0.8. While doing that I made some changes and fixes for various things. Some notes on your diff:</div><div><ul><li>Firstly, I made use of some of the fixes in your patch for the fileflags and crtimes patches -- thanks!</li>
<li>Your patch set an ITEM_REPORT_XATTR flag in a FLAG_* variable, which really set FLAG_HLINK_DONE, which is potentially harmful for the code's ability to retrieve values for a file's data. While it would have been possible to change this to a new flag, I instead changed the xattr idiom to pass the compressed-data xattr as a normal abbreviated entry, but with the mtime in the checksum. This lets the code work normally to figure out if the xattr field is identical or not (and incorporates the size into the check, for added safety).</li>
<li>I got rid of the compat_flag changes in compat.c, since they are not needed and are potentially harmful for forward compatibility (if I should ever use that compatibility bit in a future release). Instead, the code in options.c dies if the option is not available.</li>
<li>The code for checking the destination file system's compression support was moved to main.c (since that is what calls it).</li><li>The repeating code that tweaks the stat-struct was moved into x_stat(), so it's in just one spot.</li>
<li>I fixed some issues that caused the "make check" tests to fail.</li><li>I changed your rsync.1 change into an rsync.yo change (since the manpages are generated from the yodl files).</li><li>I made some style changes, getting rid of trailing whitespace, using /* ... */ for comments, etc.</li>
<li>I checked in the result into the patches git repo as hfs-compression.diff.</li></ul></div><div>If you would test the result, I'd appreciate it. I verified that it compiles and passes the testsuite, but I don't currently have any compressed files to test it against.</div>
<div><br></div><div>To snag the code, either grab things from git or download a tar file of the resulting code. The git method:</div><div><br></div></div><blockquote class="webkit-indent-blockquote" style="margin: 0 0 0 40px; border: none; padding: 0px;">
<div class="gmail_quote"><div><font class="Apple-style-span" face="'courier new', monospace">git clone git://<a href="http://git.samba.org/rsync">git.samba.org/rsync</a></font></div></div><div class="gmail_quote">
<div><font class="Apple-style-span" face="'courier new', monospace">git clone git://<a href="http://git.samba.org/rsync-patches">git.samba.org/rsync-patches</a> rsync/patches</font></div></div><div class="gmail_quote">
<div><font class="Apple-style-span" face="'courier new', monospace">cd rsync</font></div></div><div class="gmail_quote"><div><font class="Apple-style-span" face="'courier new', monospace">git checkout b3.0.x</font></div>
</div><div class="gmail_quote"><div><font class="Apple-style-span" face="'courier new', monospace">cd patches</font></div></div><div class="gmail_quote"><div><font class="Apple-style-span" face="'courier new', monospace">git checkout b3.0.x</font></div>
<div><font class="Apple-style-span" face="'courier new', monospace">cd ..</font></div></div></blockquote><div class="gmail_quote"><div><br></div><div>Then just follow the directions in the patches/hfs-compression.diff for applying the 3 patches and compiling.</div>
<div><br></div><div>Or you can snag this tar file which has all the patches applied:</div><div><br></div></div><blockquote class="webkit-indent-blockquote" style="margin: 0 0 0 40px; border: none; padding: 0px;"><div class="gmail_quote">
<div><a href="http://opencoder.net/rsync-hfs-compression.tar.gz">http://opencoder.net/rsync-hfs-compression.tar.gz</a></div></div></blockquote><div class="gmail_quote"><div><br></div></div>..wayne..<br>