<br><br><div class="gmail_quote">On Tue, May 18, 2010 at 6:17 AM, Jeff Layton <span dir="ltr"><<a href="mailto:jlayton@samba.org">jlayton@samba.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div><div></div><div class="h5"><br></div></div>
There's really no need to assign every value on an enum. You should<br>
also probably prefix these with the semi-standard "Opt_" so that they<br>
aren't confused with other values. This should also be static, I think.<br>
<div><div></div><div class="h5"><br></div></div></blockquote><div>Agreed on Opt prefix. I only used the enum as it was the preferred way to define related constants in the kernel coding style; TBH, I'd rather just use #define'd constants. If it's all the same, that's what I'll do. It means I won't have to fight with keeping the alignment in vim the same as what gets emailed (those values were all aligned in the file and the patch file). :)</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div><div class="h5">
<br>
</div></div>This looks like a step in the right direction, but I'll note that the<br>
kernel already has a standard mount option parser. See match_token().<br>
For an example of how it's used, you can look at the NFS code, starting<br>
with nfs_parse_mount_options.<br>
<br></blockquote><div>Aha! </div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
It would be best to move to that code if possible<font color="#888888"><br></font></blockquote><div>Agreed. </div><div> </div></div><br>-- <br>Peace and Blessings,<br>-Scott.<br><br>