<br><br><div class="gmail_quote">On Fri, Apr 16, 2010 at 5:32 PM, Scott Lovenberg <span dir="ltr"><<a href="mailto:scott.lovenberg@gmail.com" target="_blank">scott.lovenberg@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#ffffff" text="#000000"><div><div></div><div>
Jeff Layton wrote:
<blockquote type="cite">
<pre>On Thu, 15 Apr 2010 01:06:55 -0400
Scott Lovenberg <a href="mailto:scott.lovenberg@gmail.com" target="_blank"><scott.lovenberg@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<pre>Just wondering if SAFE_FREE(char*) has to be called on temp_val in
open_cred_file() of mount.cifs.c. Unless I'm missing something, a parsed
password will be left in temp_val because it never gets zeroed out.
</pre>
</blockquote>
<pre>Yeah, looks like something that should be fixed. In fact, that whole
function needs some overhaul -- the magic 4096/4086/4087 numbers in it
are pretty yucky and make it hard to tell what's going on. That should
use a #define'd constant. Also, the user= field should probably be
fixed so that it uses parse_username() too.
Care to send a patch? If not, I'll plan to fix that sometime before the
next release.
Thanks,
</pre>
</blockquote></div></div></div></blockquote></div>Scratch that... I meant a call to memset(), not SAFE_FREE().<br><br><div>I've got a patch set, I just have to test it. I'll commit and email tonight.<br clear="all">
<br>-- <br>Peace and Blessings,<br>
-Scott.<br><br>
</div>