<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Jeff Layton wrote:
<blockquote cite="mid:20100416071208.6403f65c@tlielax.poochiereds.net"
type="cite">
<pre wrap="">On Thu, 15 Apr 2010 01:06:55 -0400
Scott Lovenberg <a class="moz-txt-link-rfc2396E" href="mailto:scott.lovenberg@gmail.com"><scott.lovenberg@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Just wondering if SAFE_FREE(char*) has to be called on temp_val in
open_cred_file() of mount.cifs.c. Unless I'm missing something, a parsed
password will be left in temp_val because it never gets zeroed out.
</pre>
</blockquote>
<pre wrap=""><!---->
Yeah, looks like something that should be fixed. In fact, that whole
function needs some overhaul -- the magic 4096/4086/4087 numbers in it
are pretty yucky and make it hard to tell what's going on. That should
use a #define'd constant. Also, the user= field should probably be
fixed so that it uses parse_username() too.
Care to send a patch? If not, I'll plan to fix that sometime before the
next release.
Thanks,
</pre>
</blockquote>
I'll take a closer look at it tonight. There were a few other things
that really bugged me about the thing, but I want to be sure I don't
cause any regressions. Working and ugly trumps shiny and broken :)<br>
</body>
</html>