On 10 September 2010 18:11, Jeremy Murphy <span dir="ltr"><<a href="mailto:jeremy.william.murphy@gmail.com">jeremy.william.murphy@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="gmail_quote"><div class="im">On 10 September 2010 05:53, Fergus Henderson <span dir="ltr"><<a href="mailto:fergus@google.com" target="_blank">fergus@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="gmail_quote"><div>On Wed, Sep 8, 2010 at 8:46 PM, Jeremy Murphy <span dir="ltr"><<a href="mailto:jeremy.william.murphy@gmail.com" target="_blank">jeremy.william.murphy@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>have you had a chance to look at the patch I submitted for issue #36 (<span>distcc-mon-gnome displays multiple rows for same host/slot)? Any thoughts? Cheers.<br></span></blockquote><div><br></div></div>
<div>I've had a brief glance, but the only thing I learned from that is that this is a tricky issue and that a brief glance won't suffice.</div></div></blockquote></div><div><br>Although my patch touches a lot of files, it essentially makes the same few changes to a number of locations.<br>
It's more complex than cheepero's patch because I didn't want to clobber any data that might be useful.<br><br><br></div><div class="im"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="gmail_quote"><div></div><div>Did you see cheepero's response, with his patch?</div><div>Can you comment on his patch?</div></div></blockquote></div><div><br>A simpler patch such as cheepero's would be ideal, however, I just tested it and it actually made things worse. I'll get in touch directly with them to convey the details. Cheers.<br>
</div></div></blockquote><div><br>After some discussion, cheepero agrees that my patch is the better idea. Someone else from Gentoo has tested it with success too. I have uploaded an updated, tidier patch, so I would encourage everyone to test it out. It doesn't affect anything other than state files, so there is minimal risk involved.<br>
<br>A related thought: might it be worth merging the lock and state mechanisms so that it is simpler and, presumably, faster? I can understand that you might want to keep locking as simple as possible though since it is so crucial. Cheers.<br>
<br>Jeremy<br><br></div></div>