On Thu, Oct 15, 2009 at 12:14 PM, Tim Dossett <span dir="ltr"><<a href="mailto:timothy.dossett@gmail.com">timothy.dossett@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Thanks for the comments.<br><br>I'll re-baseline to the current SVN; might take a week or so since this is a spare time job for me.<br><br>Since the -x option only explicitly tells gcc what the source is supposed to be, shouldn't distcc already support -x c, -x c++ and -x objective-c?</blockquote>
<div><br>I think distcc has some code that makes assumptions about the language based on the file extension.<br>That code would need to change in order to properly support "-x".<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
The reason I added code to support -x is the ada multi-language build tool "gprbuild" by default adds -x for all languages it supports. Haven't tried mixing the -x option with the wrong source type.<br></blockquote>
<div><br>Maybe you could change the distcc code so that distcc supports "-x" only in the cases where the "-x" option has no effect?<br>That might be easier than supporting it properly, and might be sufficient for use with "gprbuild".<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Agree that max_discrepancies_before_demotion = 10000000 (or whatever large number) is wrong for c/c++ and ada too, but 1 seems too strict. I think 10 sounds more reasonable, allowing some remote compile failures without reverting to non-pump compiles. It would be nice to make this user configurable without recompiling.<br>
</blockquote><div><br>I agree and I would be very happy to accept a patch along these lines.<br> </div>Cheers,<br> Fergus.<br></div><br>-- <br>Fergus Henderson <<a href="mailto:fergus@google.com">fergus@google.com</a>><br>