[cifs-protocol] [EXTERNAL] Re: [REG:120063021002364] Clarification on length limit in SMB2_FILE_RENAME_INFORMATION filename

[Obaid Farooqi]

Hi Jeremy:
The size of the rename info in the packet is compared to the sizeof(FILE_RENAME_INFORMATION_TYPE_1). MS-FSCC shows on the wire format (serialized). In code the size of this structure is 24 bytes. In case of one character the size becomes 22 and an error is generated since this is lower than 24. In all other cases i.e. 2 characters or more, the length will be 24 or more.

I have filed a bug to document this.

Regards,
Obaid Farooqi
Escalatiion Engineer | Microsoft

-----Original Message-----
From: Jeremy Allison <jra at samba.org> 
Sent: Monday, July 6, 2020 1:59 PM
To: Obaid Farooqi <obaidf at microsoft.com>
Cc: cifs-protocol at lists.samba.org; slow at samba.org; support <support at mail.support.microsoft.com>
Subject: [EXTERNAL] Re: [REG:120063021002364] Clarification on length limit in SMB2_FILE_RENAME_INFORMATION filename

On Mon, Jul 06, 2020 at 06:18:54PM +0000, Obaid Farooqi wrote:
> Hi Jeremy:
> I'll help you with this issue and will be in touch as soon as I have an answer.
> 
> Regards,
> Obaid Farooqi
> Escalatiion Engineer | Microsoft

Thanks Obaid. I'm pretty sure you're going to find a:

	if (length < 24) {
		return NT_STATUS_INFO_LENGTH_MISMATCH;
	}

somewhere in the server code processing SMB2_FILE_RENAME_INFORMATION requests :-).

Jeremy.