[cifs-protocol] [REG:119070521001876] SMB3 LZ77 decompression issues

[Edgar Olougouna]

Metze,

You observation is correct. It should be 4 bytes, instead of 8 bytes. Thanks for catching!
37
+
                    If MatchLength == 0
38
+
                        MatchLength = read 4 bytes from InputPosition
39
+
                        InputPosition += 4 bytes



Thanks,

Edgar



-----Original Message-----
From: Stefan Metzmacher <metze at samba.org>
Sent: Monday, July 15, 2019 3:14 AM
To: Edgar Olougouna <edgaro at microsoft.com>; Aurélien Aptel <aaptel at suse.com>; cifs-protocol at lists.samba.org
Cc: support <support at mail.support.microsoft.com>
Subject: Re: [cifs-protocol] [REG:119070521001876] SMB3 LZ77 decompression issues



Hi Edgar,



> Upon review, we noticed there is additional logic to handle values larger than 1 << 16 for the MatchLength. The second change here is that the we subtract 15 from the MatchLength instead of 15 + 7.  See additions on lines 37 to 39. Let us know whether this helps.



> 37

> +

>                     If MatchLength == 0

> 38

> +

>                         MatchLength = read 8 bytes from InputPosition

> 39

> +

>                         InputPosition += 8 bytes



Shouldn't this be 4 bytes instead of 8?



metze






-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.samba.org/pipermail/cifs-protocol/attachments/20190715/5ebe574f/attachment.htm>