[Samba] Printing XP -> 3.2 Now really slow (just like the old days)

[Jeremy Allison]

On Thu, Aug 14, 2008 at 02:01:26AM -0500, David C. Rankin wrote:
> Guys,
>
> 	My wife needed to print something this evening to our normal HP 4 
> attached to our cups server running samba-3.2.1-0.1.126. Nothing has 
> changed in the last two months going from 3.0.28a to the 3.2.x flavor of 
> samba. However, something has brought printing to its knees.
>
> 	I pulled out all the old tricks, hacked the registry to delete any 
> entries in HKCU\Printers\DevModes and DevModes2 of the type 
> \\server\printer. Removal of the entries didn't change a thing. I 
> captured an ethereal/wireshark trace and I have that available to anyone 
> if interested.
>
> 	Have there been any changes in 3.2.x that would effect printing? It does 
> seem to print once every conceivable timer in window times out, but were 
> talking 120-150 seconds. Any Ideas?

There's a bug with a missing reply_printclose() that just
got fixed in the tree by Bartosz Antosik that may be
causing this. It could cause print jobs to timeout
on the Windows side.

Patch is attached, and it will be in 3.2.2.

Jeremy.
-------------- next part --------------
diff --git a/source/smbd/reply.c b/source/smbd/reply.c
index ef49d58..88c8ae8 100644
--- a/source/smbd/reply.c
+++ b/source/smbd/reply.c
@@ -4672,6 +4672,8 @@ void reply_printclose(struct smb_request *req)
 		return;
 	}
 
+	reply_outbuf(req, 0, 0);
+
 	END_PROFILE(SMBsplclose);
 	return;
 }