[Samba] Simple fix to horrible bug in Samba website CSS

[Deryck Hodge]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gerald (Jerry) Carter wrote:
> Nick,
> 
> Is this an old message?  I thought we already talked about this?
> Deryck, don't you remember a discussion about this?
> 
> 
> 

Nope.  In fact, I never got (or noticed) this mail before now.  I don't
know what happened, but I can't even find a trace of it.  Sorry about that!

>>>>I've never noticed any of the display problems you describe.
>>>
>>>Because you never pressed Ctrl-+ many times in Firefox until the font
>>>became larger than the fixed size of 20 pixels.
>>>
>>>I have attached two screen images of the menu, one with the default
>>>CSS, the other with the following simple patch applied.

I agree this needs to be fixed.  You're just the first to report problems
on really high resolutions.  I guess most people who use high resolutions
generally like the tiny fonts. :-)

>>>
>>>$ diff -u main.css-orig main.css
>>>--- main.css-orig       2005-06-08 19:19:21.000000000 +1000
>>>+++ main.css    2005-06-08 19:18:55.000000000 +1000
>>>@@ -161,7 +161,7 @@
>>> .nav a:link,
>>> .nav a:visited {
>>>        display:block;
>>>-       height:20px;
>>>+       #height:20px;
>>>        font-size:small;
>>>        color:#2B5C9F;
>>> }
>>>
>>>Trust me, it needs fixing.
>>>

And trust me, it will be. :-) Although, your solution isn't acceptable.
What are you trying to do, comment out the height?  The hash hack generates
parse errors on CSS validators, and it doesn't work consistently.  Were you
trying to hide the style from Firefox while leaving it visible to other
browsers?

The simplest solution is to not specify a height at all, but as I say, I
think I did this for a reason (i.e. trying to fix a bigger, more obvious
problem.)  I'm hesitant to remove the height rule without testing across
multiple browsers, which I can't do today.

I will put this on my todo list.  If you don't see a fix by the middle of
next week, feel free to email me personally about it.

Cheers,
deryck

btw, I'm glad the bug didn't bother you so bad as to prevent you from using
the styles on your own website.

- --
Deryck Hodge                            http://www.devurandom.org/
Samba Team                              http://www.samba.org/
"...it is not the spoon that bends, it is only yourself." --from The Matrix
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCwsPL4glRK0DaE8gRAmoAAJ99aVE5QqgaRzyOYJULRIBdLQCiVACcD4hT
ty1nJYUlLpsb3EnCw4Nclm4=
=+wSA
-----END PGP SIGNATURE-----