[Samba] smbclient fails to list directory >36 entries

[Tony Earnshaw]

tor, 23.06.2005 kl. 17.58 skrev Jeremy Allison:

> > I have a problem with smbclient from the samba-client-3.0.14a-2 package 
> > supplied with Fedora Core 2.  It hangs when listing any directory with 
> > over 36 items in it on one particular Windows XP Professional box I'm 
> > trying to back up.  If I run smbclient -d 3, I get the following output 
> > over and over when listing the directory:
> > 
> > received 36 entries (eos=0)
> > received 36 entries (eos=0)
> > received 36 entries (eos=0)
> > received 36 entries (eos=0)
> > received 36 entries (eos=0)
> > received 36 entries (eos=0)
> > received 36 entries (eos=0)
> > received 36 entries (eos=0)
> > received 36 entries (eos=0)
> > received 36 entries (eos=0)
> > received 36 entries (eos=0)
> > received 36 entries (eos=0)
> > 
> > Anyone got any clues what might be wrong here?
> 
> This is a bug we fixed when listing files from an exported
> drive using a FAT filesystem. Try the 3.0.20 pre-release, the
> bug is fixed there.

Or, alternatively (no way you'd get me onto a Samba pre-release) OP
could apply the patch (attached) you yourself gave on 7-04-05 and which
works for our sites on 3.0.14a.

Best,

--Tonni

-- 
mail: tonye at billy.demon.nl
http://www.billy.demon.nl

-------------- next part --------------
--- smbd/dir.c	2005-03-23 12:30:27.000000000 -0800
+++ /home/jeremy/src/samba3.0/source/smbd/dir.c	2005-04-06 18:57:46.157484483 -0700
@@ -602,7 +603,7 @@
 		return False;
 	}
 
-	while (SearchDir(dptr->dir_hnd, name, poffset) == True) {
+	if (SearchDir(dptr->dir_hnd, name, poffset)) {
 		if (is_visible_file(dptr->conn, dptr->path, name, pst, True)) {
 			return True;
 		}