[Samba] Error with ACLs and follow symlinks=no

[Jeremy Allison]

On Tue, Nov 16, 2004 at 04:07:15PM -0800, Tom Dickson wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> We had 3.0.2a which worked fine. If you tried to open a file that the
> ACLs wouldn't let you, you'd get access denied. We had follow
> symlinks=no in smb.conf
> 
> Now with 3.0.8, and no other changes, we get a message about "The file
> has moved or otherwise gone away," instead of access denied.
> 
> And we get this in the log file:
> 
> [2004/11/16 15:57:25, 1] smbd/vfs.c:reduce_name(896)
> ~  reduce_name: couldn't get realpath for B/*
> 
> Changing follow symlinks=yes fixed it. Is this a bug? I'd like to use
> ACLs and follow symlinks=no.

Yep it's a bug. Try this patch.

Jeremy.

Index: smbd/vfs.c
===================================================================
--- smbd/vfs.c  (revision 3814)
+++ smbd/vfs.c  (working copy)
@@ -897,7 +897,8 @@
                        }
                        default:
                                DEBUG(1,("reduce_name: couldn't get realpath for %s\n", fname));
-                               errno = saved_errno;
+                               /* Don't restore the saved errno. We need to return the error that
+                                  realpath caused here as it was not one of the cases we handle. JRA. */
                                return False;
                }
        }