[Samba] Samba 3.0rc3 - German Umlauts

[Jeremy Allison]

On Tue, Sep 09, 2003 at 06:16:19PM +0200, Gunther Schlegel wrote:
> Hi,
> 
> I have the same problem on RedHat9 with Samba 3rc3, Client Win XP (
> German ), all smb.conf charset settings pointing to defaults (UTF-8). 
> 
> It did work with rc1. This is a showstopper if it is not related to
> configuration errors.
> 
> from smbd.log:
> [2003/09/09 16:10:26, 0] smbd/statcache.c:stat_cache_add(123)
>   OOPS - tried to store stat cache entry for werid length paths [P�] 2
> and [päm]
>  4)!
> [2003/09/09 16:10:26, 0] smbd/statcache.c:stat_cache_add(123)
>   OOPS - tried to store stat cache entry for werid length paths [P�] 2
> and [päm]
>  4)!

Please try the following patch, and see if it fixes the problem.
It just missed the RC3 cutoff but is in CVS.

Jeremy.

--- lib/charcnv.c       Mon Sep  8 07:13:30 2003
+++ /home/jeremy/src/samba3.0/source/lib/charcnv.c      Mon Sep  8 14:27:10 2003
@@ -270,7 +270,7 @@
                                        break;
                        } else {
                                if (srclen == (size_t)-1) {
-                                       srclen = strlen(src)+1;
+                                       srclen = strlen(p)+1;
                                }
                                return retval + convert_string_internal(from, to, p, srclen, q, destlen);
                        }
@@ -296,7 +296,7 @@
                                        break;
                        } else {
                                if (srclen == (size_t)-1) {
-                                       srclen = strlen_w(src)+2;
+                                       srclen = strlen_w((const void *)p)+2;
                                }
                                return retval + convert_string_internal(from, to, p, srclen, q, destlen);
                        }
@@ -322,7 +322,7 @@
                                        break;
                        } else {
                                if (srclen == (size_t)-1) {
-                                       srclen = strlen(src)+1;
+                                       srclen = strlen(p)+1;
                                }
                                return retval + convert_string_internal(from, to, p, srclen, q, destlen);
                        }