Simplify copy-reflink code

Ralph Boehme slow at samba.org
Fri Apr 5 14:15:20 UTC 2024


On 4/5/24 12:54, David Disseldorp wrote:
> Interesting, thanks! What about unaligned lengths when it covers the end
> of a file?

In my testing with btrfs it seems btrfs allows this if it covers the 
*complete* last chunk of the file, eg from an strace of a copy a file of 
4160 bytes:

ioctl(33, FICLONERANGE, {src_fd=32, src_offset=4096, src_length=64, 
dest_offset=4096}) = 0

Both offsets are aligned and src_offset + src_length is the file size, 
so it works.

But according to the customer this may not be the case with ZFS, still 
digging...

Thanks!
-slow
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20240405/db7de899/OpenPGP_signature.sig>


More information about the samba-technical mailing list