Simplify copy-reflink code

Ralph Boehme slow at samba.org
Tue Apr 2 13:43:44 UTC 2024


Hi David,

thanks for taking a look!

On 4/2/24 11:26, David Disseldorp wrote:
> Sounds good to me, although I'll need a bit of time this week to take a
> look (and do some testing).

that would be awesome!

> If it's passing the copy-chunk & dup-extent
> torture tests on a btrfs-backed share, then I'm confident that it should
> be fine. 

yes, they're still passing.

> However, my confidence in the tests is reduced - I thought they
> exercised the BTRFS_IOC_CLONE_RANGE fallback code-path, so should have
> caught [1]. Perhaps it's just that nobody tests atop btrfs?

I guess for the common workload of copying files the fallback is just 
never triggered.

-slow

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20240402/53a4c9aa/OpenPGP_signature.sig>


More information about the samba-technical mailing list