[PATCH/RFC] Use submodule for dnspython
Jelmer Vernooij
jelmer at samba.org
Sat May 9 17:20:48 MDT 2015
TL;DR: This patch removes our copy of dnspython from the tree and instead
puts a submodule in place.
Benefits
========
This should make updates of external libraries (just dnspython for
now) easier to review in the future as you'll just see a one-line diff
updating it to a new upstream SHA. This way we can also easily verify we don't
have any local changes.
We currently use a mirror of the upstream dnspython repository that is
hosted on git.samba.org - just in case upstream changes their URL.
What changes for users
======================
A consequence of this is that if "dnspython" is not installed on the
system and if samba wasn't cloned using 'git clone --recursive',
the user will get the following message during configure:
ERROR: Unable to find Python module 'dnspython'. Please install the
system package or check out the relevant submodule by running
'git submodule update --init'.
(Previously Samba would automatically use the bundled version)
Cheers,
Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: submodule-dnspython.diff
Type: text/x-diff
Size: 34053 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150509/47f0b84a/attachment.diff>
More information about the samba-technical
mailing list