回复:[PATCH 1/3 v3] dcache: Don't take unnecessary lock in d_count update
Waiman Long
waiman.long at hp.com
Thu May 23 14:51:47 MDT 2013
On 05/23/2013 05:09 AM, remaper wrote:
> maybe you can use the atomic_dec_and_lock(&dentry->d_count,&dentry->d_lock) here, right ?
>
> ------------------ Origin ------------------
>> The current code takes the dentry's d_lock lock whenever the d_count
>> reference count is being updated. In reality, nothing big really
>> happens until d_count goes to 0 in dput(). So it is not necessary to
>> take the lock if the reference count won't go to 0.
Thank for the suggestion.
First of all, the d_count field is not an atomic type. Changing it to
atomic will require touching quite a large number of source files even
though that change won't change the size of the dentry. Secondly, the
function internally uses cmpxchg to do its work. There isn't any
performance advantage of using it. I also need the count to go in both
direction, not just going down.
Regards,
Longman
More information about the samba-technical
mailing list