NDR_PUSH_CHECK_FLAGS and NDR_PULL_CHECK_FLAGS not defined?

[Richard Sharpe]

On Sun, 18 Sep 2011, Andrew Bartlett wrote:

> On Sat, 2011-09-17 at 16:52 -0700, Richard Sharpe wrote:
>> On Sat, Sep 17, 2011 at 4:21 PM, Richard Sharpe
>> <realrichardsharpe at gmail.com> wrote:
>>> Hi,
>>>
>>> I was trying to build 3.6.0 with my FSCTL patch cherry-picked from
>>> master and got this error:
>>>
>>> Compiling librpc/gen_ndr/ndr_libnetapi.c
>>> librpc/gen_ndr/ndr_libnetapi.c: In function ÿÿndr_push_domsidÿÿ:
>>> librpc/gen_ndr/ndr_libnetapi.c:34:2: error: implicit declaration of
>>> function ÿÿNDR_PUSH_CHECK_FLAGSÿÿ
>>> librpc/gen_ndr/ndr_libnetapi.c: In function ÿÿndr_pull_domsidÿÿ:
>>> librpc/gen_ndr/ndr_libnetapi.c:54:2: error: implicit declaration of
>>> function ÿÿNDR_PULL_CHECK_FLAGSÿÿ
>>> The following command failed:
>>> gcc -g -DDEBUG_PASSWORD -DDEVELOPER -g -Wall -Wshadow -Wpointer-arith
>>> -Wcast-align -Wwrite-strings -Wdeclaration-after-statement
>>> -Werror-implicit-function-declaration -I.
>>> -I/home/rsharpe/samba/source3
>>> -I/home/rsharpe/samba/source3/../lib/iniparser/src -Iinclude
>>> -I./include  -I. -I. -I./../lib/replace -I./../lib/tevent -I./librpc
>>> -I./.. -I./../lib/talloc -I../lib/tdb/include -DHAVE_CONFIG_H
>>> -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
>>> -DLDAP_DEPRECATED  -I/home/rsharpe/samba/source3/lib -I..
>>> -D_SAMBA_BUILD_=3 -D_SAMBA_BUILD_=3 -fPIC -c
>>> librpc/gen_ndr/ndr_libnetapi.c -o librpc/gen_ndr/ndr_libnetapi.o
>>> make: *** [librpc/gen_ndr/ndr_libnetapi.o] Error 1
>>>
>>>
>>> What would cause this? Looks like some intermediate file has not been
>>> rebuilt ...
>>
>> OK, found the problem. Neither 'make clean' nor 'make distclean' etc
>> remove the files generated from IDL.
>>
>> Since I was moving from master back to 3.6.0 there were differences.
>
> The issue here is that for a release, we autogenerate these files with
> autogen.sh and include them in the tarball.  This means we can't clean
> them with either clean or distclean, as otherwise it would remove
> them.

Yes, I realized after I wrote that that there are issues with respect to 
the tarball ...

Just have to remember to clean out the generated files in future if I am 
moving back and forward between releases.

Regards
-------
Richard Sharpe, rsharpe[at]richardsharpe.com, rsharpe[at]samba.org,
sharpe[at]ethereal.com, http://www.richardsharpe.com