[SCM] Samba Shared Repository - branch master updated
Jeremy Allison
jra at samba.org
Fri May 6 08:49:18 MDT 2011
On Fri, May 06, 2011 at 07:51:01AM +0200, Andrew Tridgell wrote:
> The branch, master has been updated
> via f455772 s3-winbind: another strlcpy()/fstring fix
> via 2fc8ad8 s3-auth: fixed bug with usernames longer than sizeof(char *)
> from 153a091 Fix const in smbtorture.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
> commit f455772b99dec88ae0eafc3206d42d88de89461d
> Author: Andrew Tridgell <tridge at samba.org>
> Date: Fri May 6 14:49:36 2011 +1000
>
> s3-winbind: another strlcpy()/fstring fix
>
> Autobuild-User: Andrew Tridgell <tridge at samba.org>
> Autobuild-Date: Fri May 6 07:50:33 CEST 2011 on sn-devel-104
>
> commit 2fc8ad88871bf8287e22cc13cea5d4dc4ddbeb61
> Author: Andrew Tridgell <tridge at samba.org>
> Date: Fri May 6 14:00:27 2011 +1000
>
> s3-auth: fixed bug with usernames longer than sizeof(char *)
>
> using sizeof(user) when user is "fstring user" as a C parameter
> actually returns sizeof(char *), which means that long usernames
> aren't allowed.
>
> Jeremy, you need a longer username :-)
>
> Cheers, Tridge
Thanks for that - I re-checked all other uses of strlcpy
and can't see any other mistakes like that.
I'm going to claim victory in that I only made 2 mistakes
in that entire stream of removing safe_strXXX (and make
test couldn't catch it because of my username :-).
Jeremy.
More information about the samba-technical
mailing list