[PATCH REVIEW] s3-auth

[Andrew Bartlett]

On Tue, 2011-06-21 at 16:04 +0200, Andreas Schneider wrote:
> On Tuesday 21 June 2011 12:04:52 you wrote:

> > I do have some concerns however:
> > 
> > With these two patches (introducing and then using the
> > get_remote_hostname() function), I'm concerned that we are doing a lot
> > of DNS work for each packet.  I do see that there is some kind of cache
> > involved, but what have we gained by doing from an explicit cache to an
> > implicit one?
> > 
> > I'm of the view that we should avoid implicit and static caches where
> > possible.  Why does the move to tsocket require this?
> > 
> > s3-smbd: Replace client_id in smbd process.
> > http://git.samba.org/?p=asn/samba.git;a=commitdiff;h=614613680ae4fb9f3d50e96
> > 3c7759866cadca6ce
> > 
> > s3-util: Add a get_remote_hostname() function.
> > http://git.samba.org/?p=asn/samba.git;a=commitdiff;h=49b23dce25cdeacb3538e2e
> > 0674d026b02e03cee
> 
> I've discussed this with metze how it should be done before I implemented it. 
> I think we can cache it in smbd_server_connection. I will implement it and 
> come back to you.

Why not just keep the client_address but change the addr element from a
string into a tocket_address?

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org