Samba oplock level II problem

Pavel Shilovsky piastryyy at gmail.com
Mon Jan 31 00:38:14 MST 2011


2011/1/30 Volker Lendecke <Volker.Lendecke at sernet.de>:
> On Sun, Jan 30, 2011 at 03:40:10PM +0300, Pavel Shilovsky wrote:
>> I fixed the problem with this patch
>> http://git.etersoft.ru/people/piastry/packages?p=samba4.git;a=commitdiff;h=5a2e2f42dc228140ab6a0a142f0fb67201461cf2
>>
>> I also mentioned that Samba use the same fsp (passed to
>> contend_level2_oplocks_begin_default) for every share entry of the
>> current pid. That's why Samba send oplock break only to only fid of
>> this pid.
>>
>> This patch is going to fix this problem:
>> http://git.etersoft.ru/people/piastry/packages/?p=samba4.git;a=commitdiff;h=d412e4639223e301380e50b5df398a2ed4077c20
>
> Thanks a lot for making the patches available in git format.
> They look very good. I have to look at the server side patch
> much more closely, this code is tricky as you will have
> found out yourself!
>
> Volker
>
> --
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
>

I've just noticed that Samba code raises a debug message if
initial_break_processing returns NULL. I recreated my second patch
according to it (created new branch master-2 and left old one too for
easy comparison):
http://git.etersoft.ru/people/piastry/packages/?p=samba4.git;a=commitdiff;h=569ee7e3553b4e2fb0b098cca9d1a32ddc7afee6

-- 
Best regards,
Pavel Shilovsky.


More information about the samba-technical mailing list