[SCM] Samba Shared Repository - branch master updated

[Volker Lendecke]

On Mon, Feb 28, 2011 at 10:44:01PM +0100, Jeremy Allison wrote:
> The branch, master has been updated
>        via  f7b4209 Fix one more warning introduced by changing the size of UNIX_USER_TOKEN->ngroups from size_t to uint32_t.
>        via  8238357 Fix warning introduced by changing the size of UNIX_USER_TOKEN->ngroups from size_t to uint32_t.
>        via  410f9fa Fix "cast from pointer to integer of different size" warnings on a 64-bit machine.
>       from  b077ccc ntvfs: Add some missing dependencies on tevent/events.
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit f7b4209f999d9c5310865381b1598668f9bcb98f
> Author: Jeremy Allison <jra at samba.org>
> Date:   Mon Feb 28 12:38:18 2011 -0800
> 
>     Fix one more warning introduced by changing the size of UNIX_USER_TOKEN->ngroups from size_t to uint32_t.
>     
>     Autobuild-User: Jeremy Allison <jra at samba.org>
>     Autobuild-Date: Mon Feb 28 22:43:50 CET 2011 on sn-devel-104
> 
> commit 8238357ac77d81a18f3faa822dafba954bba7b86
> Author: Jeremy Allison <jra at samba.org>
> Date:   Mon Feb 28 12:31:53 2011 -0800
> 
>     Fix warning introduced by changing the size of UNIX_USER_TOKEN->ngroups from size_t to uint32_t.
> 
> commit 410f9fad6c49e1af4e9700331aa2e1ed16f51b27
> Author: Jeremy Allison <jra at samba.org>
> Date:   Mon Feb 28 12:25:40 2011 -0800
> 
>     Fix "cast from pointer to integer of different size" warnings on a 64-bit machine.

Jeremy, I think this is the wrong fix. I have sent a patch
to Tridge CC samba-technical that fixes it in a different
way. Can you please coordinate with Tridge about the proper
way to fix this? I did not push it directly with the big
stream because this touches a core definition of tevent,
which needs proper approval by Tridge.

Despite it might seem that I am neglecting my code, I'm
trying my best to take care of it and get it into proper
shape.

What is your argument against my fix with the union? Is that
not portable enough? Is it too much bloat?

With best regards,

Volker Lendecke

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen