[SCM] Samba Shared Repository - branch v3-6-test updated

Jeremy Allison jra at samba.org
Tue Feb 15 18:32:20 MST 2011


On Wed, Feb 16, 2011 at 12:28:54PM +1100, Andrew Bartlett wrote:
> On Wed, 2011-02-16 at 02:27 +0100, Jeremy Allison wrote:
> > The branch, v3-6-test has been updated
> >        via  518f1a2 s3-auth Fix memory leak in security=share and force user =
> >        via  320e549 Merge branch 'v3-6-test' of ssh://git.samba.org/data/git/samba into v3-6-test
> >        via  25e21dc tdb: Fix a C++ warning
> >       from  ccb3d5e s3-librpc: move server_id marshalling to own helper file.
> > 
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
> > 
> > 
> > - Log -----------------------------------------------------------------
> > commit 518f1a2a35920ebf43c29b163a5091a9d92b5264
> > Author: Andrew Bartlett <abartlet at samba.org>
> > Date:   Fri Feb 11 11:34:56 2011 +1100
> > 
> >     s3-auth Fix memory leak in security=share and force user =
> >     
> >     In these cases, the server_info was not stolen onto a long term memory
> >     context, and so remained on the NULL context where it was created.
> >     
> >     Andrew Bartlett
> >     
> >     Autobuild-User: Andrew Bartlett <abartlet at samba.org>
> >     Autobuild-Date: Wed Feb 16 01:08:19 CET 2011 on sn-devel-104
> >     (cherry picked from commit 1354d3dc747344390302e3fd2a202ff372985a9c)
> 
> Thanks for that.  I suspect it may apply to earlier branches as well,
> but I've not looked into the details yet. 

Yeah, made me start looking at the memory heirarchy in the auth code
a little more closely. Unfortunately it's a mess :-(. Pre talloc_stackframe()
code :-(.

Jeremy.


More information about the samba-technical mailing list