Bug in samldb_description_check?

[Matthias Dieter Wallnöfer]

Hi Volker,

I believe that the attached patch fixes the issue for your particular 
issue. But say if have unnormalised requests (multiple adds, replaces, 
deletes in an arbitrary order) always on the same attribute it won't do 
it's job.
To do it right we would have to apply manually all changes on the actual 
"description" attribute in "samldb_description_check" and check the 
result. An example would be the handling of the "objectclass" attribute 
in the "objectclass" LDB module.

So if you would like to apply this as an intermediate solution, fine. 
Anyway we should also think about a "description" test enhancement in 
"sam.py".

Regards,
Matthias

Volker Lendecke wrote:
> On Sun, Feb 13, 2011 at 06:44:34PM +0300, Matthieu Patou wrote:
>    
>> dn: CN=vl,CN=Users,DC=samba,DC=org
>> changetype: modify
>> replace: description
>> description: bar
>>      
> It probably would, but I would like to use the very limited
> "transaction" safety LDAP gives us. With the del/add style
> modifications pdb_ads can make reasonably sure that nobody
> changed the value behind its back.
>
> The attached patch fixes the issue for me.
>
> With best regards,
>
> Volker
>
>