samldb and associated patches

[Kamen Mazdrashki]

Hi Matthias, Andrew,

Thanks for spotting&fixing delete object functionality!


On Fri, Sep 24, 2010 at 03:33, Andrew Bartlett <abartlet at samba.org> wrote:

> On Wed, 2010-09-22 at 08:47 +0000, Matthias Dieter Wallnöfer wrote:
> > Hi Andrew and others,
> >
> > my work under "dsdb_work" is ready to merge.
>
> I've pushed everything except the isDeleted changes, because Kamen has
> expressed concerns about them, and wants to test them out himself.
>
> I think it is ok, except for few minor things

http://gitweb.samba.org/?p=mdw/samba.git;a=commitdiff;h=b439112915af7b6b630c8010bfc7fdcbc5b82ac8
I think we should leave Python tests with just "show_deleted:1" control.
We are deleting a normal objects and thus the result should be either
Tombstone
or Deleted-object, but no Recycled object.

http://gitweb.samba.org/?p=mdw/samba.git;a=commitdiff;h=4910268373b699b28691599bd56bd2c0cf2b8db0
The test checks only repl_meta_data.c behavior, not subtree_delete.
Do we have a test for subtree_delete module? I can't find one.
I think it is ok to go 'in' this way, but it is good for us to have
a subtree_delete tests.
<http://gitweb.samba.org/?p=mdw/samba.git;a=commitdiff;h=b439112915af7b6b630c8010bfc7fdcbc5b82ac8>


> I've also not pushed the timeout change for the reasons Kamen indicated.
>
>
http://gitweb.samba.org/?p=mdw/samba.git;a=commitdiff;h=987585e0a6fd2165841bf03eea9675fb5d7c9608
This commit really solves the problem temporary.
If you happen to browse a heavy javascript-driven by the time
you are running 'make test', you may hit this problem again :)
We either should implement this wait with several retries
or implement role transfer operation to be synchronous from
client-side point of view.


-- 
CU,
Kamen