[PATCH] FS: cifs: Fix compile warning
Steve French
smfrench at gmail.com
Mon Sep 13 10:30:27 MDT 2010
On Fri, Sep 10, 2010 at 7:45 PM, Javier Martinez Canillas
<martinez.javier at gmail.com> wrote:
> In today linux-next I got a compile warning due a possibly uninitialized variable
>
> This trivial patch solves the issue
>
> Thanks a lot
>
> Signed-off-by: Javier Martinez Canillas <martinez.javier at gmail.com>
> ---
> fs/cifs/cifssmb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
> index c65c341..ee1bba4 100644
> --- a/fs/cifs/cifssmb.c
> +++ b/fs/cifs/cifssmb.c
> @@ -3079,7 +3079,7 @@ CIFSSMBGetCIFSACL(const int xid, struct cifsTconInfo *tcon, __u16 fid,
> __u32 parm_len;
> __u32 acl_len;
> struct smb_com_ntransact_rsp *pSMBr;
> - char *pdata;
> + char *pdata = NULL;
This looks like a compiler problem - the variable is always
initialized by validate_ntransact except when
buf (which contains the smb) is null, when it returns -EINVAL and in
that case pdata is not used.
Setting it to null would not help anyway - if it were left as null it
would oops on the memcpy (where pdata is used).
This area of code has not changed recently.
--
Thanks,
Steve
More information about the samba-technical
mailing list