patch for subunithelper

Jelmer Vernooij jelmer at samba.org
Sun Nov 14 16:29:30 MST 2010


Hi Matthieu,

On Sun, 2010-11-14 at 14:59 +0300, Matthieu Patou wrote:
> can you review this patch it's design to make filter-subunit.py to exit 
> with a non zero error code if we have only 1 testsuite who has failed 
> but without any failed test (happens if the initialization of the 
> testsuite has failed, ie. because a module is missing).
> 
> An example of subunit output that shows this combination is also 
> attached to the email.
I think in this case we should just change the error code if there was a
failed testsuite without failed tests, rather than making up nonexistant
tests. Creating tests will cause havoc for test runners, since they will
not be able to request this test be run manually.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101115/d9f60414/attachment.pgp>


More information about the samba-technical mailing list